New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error/Assertion: ASSERT_QUIET_EVAL has been removed in PHP8 #1421

Closed

CatoTH opened this issue Jan 16, 2021 · 0 comments

CatoTH commented Jan 16, 2021 •

edited

Describe the bug
At https://github.com/simplesamlphp/simplesamlphp/blob/master/lib/SimpleSAML/Error/Assertion.php#L61 , assert_options(ASSERT_QUIET_EVAL, 0); is called. This fails on PHP 8, as this constant has been removed, according to https://www.php.net/manual/en/migration80.incompatible.php . (The documentation at https://www.php.net/manual/en/function.assert-options.php does not mention this, but discurages assert_options in general starting PHP 7.

In my case, this leads to an exception being thrown, breaking the authentication.

Expected behavior
This particular assert_options call is probably unnecessary starting with PHP 8.

The text was updated successfully, but these errors were encountered:

tvdijen closed this as completed in

423aa41

tvdijen added a commit that referenced this issue


          Remove unused class; closes #1421

3f31e7d

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.