Add support for PHP 8.x #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
December 10, 2021 21:52
|
Will it still work with php 7.4 if we merge this pull request? |
|
On 12/12/21 7:12 PM, Peter Bennett wrote:
Will it still work with php 7.4 if we merge this pull request?
I looked at the top level pages and scheduled a single recording OK.
That was on php 7.4/Ubuntu 20.04.
Full disclosure, I rarely use mythweb.
…--
Bill
|
|
Yes, the changes I've made are suitable for PHP 7.4 and PHP 8.x |
|
Merged into master |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've worked through a number of small issues so that MythWeb will work with PHP 8.x.
I started by fixing all major issues identifed by PhpStorm, then fixed a couple of other errors thrown as FATAL and suppressed the errors thrown as WARNING. These errors have existed for a long time, so there is no harm done by suppressing them. As MythWeb is considered to be a legacy code base, I believe that an approach such as this is acceptable.
This branch seems to work fine with PHP 8.0 and I believe it will work with PHP 8.1.
Please consider merging my pull request into the official repository. It resolves #63.